linux-kernel - Re: [PATCH] treewide: fix a bunch of typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATiEk3pvnsqpkPogNZK8Of7p0shV_xUSye=dO63xLZR4Q@mail.gmail.com>
Date:	Thu, 11 Aug 2016 22:01:04 +0900
From:	Masahiro Yamada <yamada.masahiro@...ionext.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] treewide: fix a bunch of typos

Hi Linus,

2016-08-09 3:03 GMT+09:00 Linus Torvalds <torvalds@...ux-foundation.org>:
> On Sun, Aug 7, 2016 at 6:56 AM, Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
>>
>> Sorry for chiming in at the last minute of the MW.
>>
>> I am not sure if you like this, but here is a bunch of typo fixes.
>> All of them are very trivial, but I am afraid this treewide patch is
>> conflict-prone.
>
> The worst part about patches like this is that they are a bitch to
> check. They're huge and I haev a hard time verifying that the patch
> does *exactly* what described, and there isn't something else in there
> hiding.
>
> I assume this patch was generated with a script anyway? I'd much
> rather just re-run the script itself on my tree, and that would make
> me feel less like I had to review it.
>
> So would you mind just sending me the sed-script (or whatever you used) instead?

First, I apologize for disturbing you just before the rc1 release.

This patch was generated by a sed-script and verified by my eyes,
but I did not keep the script.

It was difficult for me to write a sed script to do a perfect job.
So, I did it incrementally; run a small sed script, and then discard
unwanted/false-positive conversions by "git checkout -p".  I repeated
this process several times to build up this patch.

If you prefer a sed-script, I will give it a try once again, but it
will be impossible to produce the same result.

This patch also includes several manual fixups.

For example, "explict" was replaced with "explicit" by the script in
the following hunk, but also I noticed and fixed "a" to "an" manually.

- *  -In TLB Flush operations (Metal Fix MMU) there is a explict command to
+ *  -In TLB Flush operations (Metal Fix MMU) there is an explicit command to

Moreover, I noticed many typos in code as well as comments.

For example, I wondered if I should fix the following macro
in drivers/net/wireless/realtek/rtlwifi/wifi.h .
(rename "N_BYTE_ALIGMENT" to "N_BYTE_ALIGNMENT")

  #define N_BYTE_ALIGMENT(__value, __aligment) ((__aligment == 1) ? \
       (__value) : (((__value + __aligment - 1) / __aligment) * __aligment))

Finally, I decided to be defensive, and
I drop all changes in code by "git checkout -p".

So, if you run a sed-script in your tree,
perhaps you may want to check the result by your eyes.

Now this patch was checked by three people
(me, Randy Dunlap, Geert Uytterhoeven).

Randy pointed out some parts should be fixed.

I am happy to send v2 if desired.
If you prefer (and more trust) a sed script, I will my best to write a one.

-- 
Best Regards
Masahiro Yamada