linux-kernel - Re: [PATCH 1/4] pinctrl: st: Use second parameter to gpio specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdb9GHvb1Fxvjrg+Qb5K8z=Xqu0NkGL3Uovdh0tgrVmofg@mail.gmail.com>
Date:	Thu, 11 Aug 2016 16:07:52 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Patrice CHOTARD <patrice.chotard@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:ARM/STI ARCHITECTURE" <kernel@...inux.com>,
	Maxime Coquelin <maxime.coquelin@...com>
Subject: Re: [PATCH 1/4] pinctrl: st: Use second parameter to gpio specifier

On Wed, Aug 10, 2016 at 3:12 PM,  <patrice.chotard@...com> wrote:

> From: Patrice Chotard <patrice.chotard@...com>
>
> This patch allows to use the second parameter of gpio
> specifier, which is used to specify whether the gpio is
> active high or low.
>
> Simply remove specific of_xlate callback() and of_gpio_n_cells
> and use default one set by of_gpiochip_add() which allows
> to use second parameter gpio specifier.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@...com>
> Signed-off-by: Patrice Chotard <patrice.chotard@...com>

Patch applied.

It seems this is one of those drivers that could also implement
.set_single_ended() and support native open drain.

Either it can do so by poking that pin config directly from the
gpiochip callback or by figuring out how to interface with the
pin config backend and do it genercially... I've been thinking a
bit about that.

Yours,
Linus Walleij