linux-kernel - Re: [PATCH] perf tools mem: Fix -t store option for record command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160811144646.GC27651@kernel.org>
Date:	Thu, 11 Aug 2016 11:46:46 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Michael Petlan <mpetlan@...hat.com>
Subject: Re: [PATCH] perf tools mem: Fix -t store option for record command

Em Thu, Aug 11, 2016 at 02:00:32PM +0200, Jiri Olsa escreveu:
> On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu:
> > > Michael reported 'perf mem -t store record' being broken.
> > > The reason is latest rework of this area:
> > >   commit acbe613e0c03 ("perf tools: Add monitored events array")
> > > 
> > > We don't mark perf_mem_events store record when -t store
> > > option is specified.
> > > 
> > > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
> >          ^^^^^^
> > I'll remove this extraneous bit
> 
> well, checkpatch script complained about that when
> I did not put it there..  but I don't mind ;-)

Huh?

[acme@...et linux]$ grep Fixes /wb/1.patch 
Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
[acme@...et linux]$ scripts/checkpatch.pl /wb/1.patch 
total: 0 errors, 0 warnings, 9 lines checked

/wb/1.patch has no obvious style problems and is ready for submission.
[acme@...et linux]$ vim /wb/1.patch 
[acme@...et linux]$ grep Fixes /wb/1.patch 
Fixes: acbe613e0c03 ("perf tools: Add monitored events array")
[acme@...et linux]$ scripts/checkpatch.pl /wb/1.patch 
total: 0 errors, 0 warnings, 9 lines checked

/wb/1.patch has no obvious style problems and is ready for submission.
[acme@...et linux]$ 

- Arnaldo