linux-kernel - Re: [PATCH] eeprom: at24: check if the chip is functional in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160811155533.GA2185@katana>
Date:	Thu, 11 Aug 2016 17:55:33 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:	linux-i2c <linux-i2c@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] eeprom: at24: check if the chip is functional in probe()

> >> +     err = at24_read(at24, 0, &c, 1);
> >
> > Can't we do this before registering dummy clients and nvmem registration?
> >
> 
> It should be ok for nvmem, but I'm not sure about the clients:
> at24_translate_offset() will return one of the registered client
> structures and though it should generally work for the first byte (it
> would always be at24->client[0]), it won't be "rock solid" anymore.

Agreed.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)