linux-kernel - RE: [PATCH net 3/4] hv_netvsc: protect module refcount by checking net_device_ctx->vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR03MB253806F92978B1BF37FF306ECA1E0@DM5PR03MB2538.namprd03.prod.outlook.com>
Date:	Thu, 11 Aug 2016 15:38:06 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	KY Srinivasan <kys@...rosoft.com>
Subject: RE: [PATCH net 3/4] hv_netvsc: protect module refcount by checking
 net_device_ctx->vf_netdev



> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Thursday, August 11, 2016 6:59 AM
> To: netdev@...r.kernel.org
> Cc: devel@...uxdriverproject.org; linux-kernel@...r.kernel.org; Haiyang
> Zhang <haiyangz@...rosoft.com>; KY Srinivasan <kys@...rosoft.com>
> Subject: [PATCH net 3/4] hv_netvsc: protect module refcount by checking
> net_device_ctx->vf_netdev
> 
> We're not guaranteed to see NETDEV_REGISTER/NETDEV_UNREGISTER
> notifications
> only once per VF but we increase/decrease module refcount unconditionally.
> Check vf_netdev to make sure we don't take/release it twice. We presume
> that only one VF per netvsc device may exist.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Acked-by: Haiyang Zhang <haiyangz@...rosoft.com>