linux-kernel - Re: [PATCH 2/8] [media] v4l2-async: call registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c4b87b3-38e9-6b4e-730e-d65b0d72dd1d@osg.samsung.com>
Date:	Thu, 11 Aug 2016 12:14:01 -0400
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Sakari Ailus <sakari.ailus@....fi>
Cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 2/8] [media] v4l2-async: call registered_async after
 subdev registration

Hello Sakari,

Thanks a lot for your feedback.

On 08/11/2016 07:18 AM, Sakari Ailus wrote:
> On Thu, Aug 11, 2016 at 02:10:43PM +0300, Sakari Ailus wrote:

[snip]

>>>  
>>> +	ret = v4l2_subdev_call(sd, core, registered_async);
>>> +	if (ret < 0) {
>>> +		if (notifier->unbind)
>>> +			notifier->unbind(notifier, sd, asd);
>>> +		return ret;
>>> +	}
>>> +
>>>  	if (list_empty(&notifier->waiting) && notifier->complete)
>>>  		return notifier->complete(notifier);
>>
>> I noticed this just now but what do you need this and the next patch for?
>>
>> We already have a callback for the same purpose: it's
>> v4l2_subdev_ops.internal_ops.registered(). And there's similar
>> unregistered() callback as well.
>>

Oh, I missed we already had those calls. When adding the connector
support, I looked at struct v4l2_subdev_core_ops and didn't find a
callback that fit but didn't notice we already had a .registered()
in struct struct v4l2_subdev_internal_ops. Sorry about that...

>> Could you use these callbacks instead?

Yes, those can be used indeed. I'll post patches using that instead
and removing the .registered_async callback since as you said isn't
really needed.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America