linux-kernel - [PATCH 2/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1470933632-22133-3-git-send-email-stillcompiling@gmail.com>
Date:	Thu, 11 Aug 2016 09:40:31 -0700
From:	Joshua Clayton <stillcompiling@...il.com>
To:	Peter Chen <hzpeterchen@...il.com>, Shawn Guo <shawnguo@...nel.org>
Cc:	Joshua Clayton <stillcompiling@...il.com>,
	gregkh@...uxfoundation.org, stern@...land.harvard.edu,
	ulf.hansson@...aro.org, broonie@...nel.org, sre@...nel.org,
	robh+dt@...nel.org, dbaryshkov@...il.com, dwmw3@...radead.org,
	k.kozlowski@...sung.com, linux-arm-kernel@...ts.infradead.org,
	p.zabel@...gutronix.de, devicetree@...r.kernel.org,
	pawel.moll@....com, mark.rutland@....com,
	linux-usb@...r.kernel.org, arnd@...db.de, s.hauer@...gutronix.de,
	mail@...iej.szmigiero.name, troy.kisky@...ndarydevices.com,
	festevam@...il.com, oscar@...andei.net, stephen.boyd@...aro.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	mka@...omium.org, Peter Chen <peter.chen@....com>
Subject: [PATCH 2/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

From: Peter Chen <peter.chen@....com>

The current dts describes USB HUB's property at USB controller's
entry, it is improper. The USB HUB should be the child node
under USB controller, and power sequence properties are under
it.

Signed-off-by: Peter Chen <peter.chen@....com>
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index 3bee2f9..44b2a24 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -9,6 +9,8 @@
  *
  */
 
+#include <dt-bindings/gpio/gpio.h>
+
 / {
 	aliases {
 		backlight = &backlight;
@@ -58,17 +60,6 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		reg_usb_h1_vbus: regulator@0 {
-			compatible = "regulator-fixed";
-			reg = <0>;
-			regulator-name = "usb_h1_vbus";
-			regulator-min-microvolt = <5000000>;
-			regulator-max-microvolt = <5000000>;
-			enable-active-high;
-			startup-delay-us = <2>; /* USB2415 requires a POR of 1 us minimum */
-			gpio = <&gpio7 12 0>;
-		};
-
 		reg_panel: regulator@1 {
 			compatible = "regulator-fixed";
 			reg = <1>;
@@ -259,9 +250,16 @@
 &usbh1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbh>;
-	vbus-supply = <&reg_usb_h1_vbus>;
-	clocks = <&clks IMX6QDL_CLK_CKO>;
 	status = "okay";
+
+	usb2415: hub@1 {
+		compatible = "usb424,2514";
+		reg = <1>;
+
+		clocks = <&clks IMX6QDL_CLK_CKO>;
+		reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
+		reset-duration-us = <3000>;
+	};
 };
 
 &usdhc3 {
-- 
2.7.4