linux-kernel - Re: [PATCH net] macvtap: fix use after free for skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160811.095620.2209757084053700354.davem@davemloft.net>
Date:	Thu, 11 Aug 2016 09:56:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jasowang@...hat.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	borntraeger@...ibm.com, cornelia.huck@...ibm.com, mst@...hat.com
Subject: Re: [PATCH net] macvtap: fix use after free for skb_array during
 release

From: Jason Wang <jasowang@...hat.com>
Date: Thu, 11 Aug 2016 18:15:56 +0800

> We've clean skb_array in macvtap_put_queue() but still try to pop from
> it during macvtap_sock_destruct(). Fix this use after free by moving
> the skb array cleanup to macvtap_sock_destruct() instead.
> 
> Fixes: 362899b8725b ("macvtap: switch to use skb array")
> Reported-by: Cornelia Huck <cornelia.huck@...ibm.com>
> Tested-by: Cornelia Huck <cornelia.huck@...ibm.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Applied, thanks for fixing this so quickly Jason.