linux-kernel - Re: [REGRESSION] get_maintainer: very noisy since '-f' is optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1470948013.14552.30.camel@perches.com>
Date:	Thu, 11 Aug 2016 13:40:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION] get_maintainer: very noisy since '-f' is optional

On Thu, 2016-08-11 at 22:14 +0200, Wolfram Sang wrote:
> Hi Joe,

Hi Wolfram.

One of my favorite xkcd comics: https://xkcd.com/1172/

> commit 4cad35a7ca690eabf0d241062ce9e59693ec03e7 ("get_maintainer.pl:
> reduce need for command-line option -f") makes my scripts very noisy.

> I regularly use get_maintainer to create CC lists for patch series
> generated with coccinelle. These patch series are stored outside my
> Linux git repo. Now I get for every vcs_file_exists() a warning from
> git-ls-files:
> 
> fatal: /home/wsa/Kernel/string-refactor/usb_alloc_urb/patches/sound/usb/0001-ALSA-usb-caiaq-audio-don-t-print-error-when-allocati.patch: '/home/wsa/Kernel/string-refactor/usb_alloc_urb/patches/sound/usb/0001-ALSA-usb-caiaq-audio-don-t-print-error-when-allocati.patch' is outside repository
> 
> Git version 2.8.1 here.
> 
> Can you take care of that?

Maybe this?

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 49a00d5..aed4511 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -2136,9 +2136,11 @@ sub vcs_file_exists {
 
     my $cmd = $VCS_cmds{"file_exists_cmd"};
     $cmd =~ s/(\$\w+)/$1/eeg;		# interpolate $cmd
-
+    $cmd .= " 2>&1";
     $exists = &{$VCS_cmds{"execute_cmd"}}($cmd);
 
+    return 0 if ($? != 0);
+
     return $exists;
 }