linux-kernel - Re: [RFC PATCH] meminfo: Break apart a very long seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1470952673.14552.32.camel@perches.com>
Date:	Thu, 11 Aug 2016 14:57:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <andi@...stfloor.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [RFC PATCH] meminfo: Break apart a very long seq_printf with
 #ifdefs

On Thu, 2016-08-11 at 14:50 -0700, Andrew Morton wrote:
> On Tue,  9 Aug 2016 23:38:56 -0700 Joe Perches <joe@...ches.com> wrote:
> > Use a specific routine to emit most lines so that the code is
> > easier to read and maintain.
> huh.
> 
>    text    data     bss     dec     hex filename
>    2976       8       0    2984     ba8 fs/proc/meminfo.o before
>    2669       8       0    2677     a75 fs/proc/meminfo.o after
> 
> Nice.  I wonder why that happened.

Fewer shifts via removal of K macro.
Much smaller call stack in seq_printf.