linux-kernel - Re: [Patch v4 6/9] driver/edac/fsl_ddr: Add support of little endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Aug 2016 09:41:58 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	York Sun <york.sun@....com>
Cc:	linux-edac@...r.kernel.org, morbidrsa@...il.com, oss@...error.net,
	stuart.yoder@....com, Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Doug Thompson <dougthompson@...ssion.com>, mchehab@...nel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch v4 6/9] driver/edac/fsl_ddr: Add support of little endian

On Tue, Aug 09, 2016 at 02:55:43PM -0700, York Sun wrote:
> Get endianness from device tree. Both big endian and little endian
> are supported. Default to big endian for backward compatibility to
> MPC85xx.
> 
> Signed-off-by: York Sun <york.sun@....com>
> 
> ---
> Change log
>   v4: Absorb name changes by "Rename macros and names"
>       Drop testing for big-endian as suggested
>       Use of_property_read_bool() as suggested
>   v3: no change
>   v2: Separated from "Add support for ARM-based SoCs" patch
> 
>  .../fsl/ddr.txt}                                   |  2 +
>  drivers/edac/fsl_ddr_edac.c                        | 96 +++++++++++++---------
>  2 files changed, 58 insertions(+), 40 deletions(-)
>  rename Documentation/devicetree/bindings/{powerpc/fsl/mem-ctrlr.txt => memory-controllers/fsl/ddr.txt} (86%)

...

> @@ -95,8 +106,8 @@ static ssize_t fsl_mc_inject_data_lo_store(struct device *dev,
>  	struct mem_ctl_info *mci = to_mci(dev);
>  	struct fsl_mc_pdata *pdata = mci->pvt_info;
>  	if (isdigit(*data)) {
> -		out_be32(pdata->mc_vbase + FSL_MC_DATA_ERR_INJECT_LO,
> -			 simple_strtoul(data, NULL, 0));
> +		ddr_out32(pdata->mc_vbase + FSL_MC_DATA_ERR_INJECT_LO,
> +			  simple_strtoul(data, NULL, 0));
>  		return count;
>  	}
>  	return 0;

WARNING: simple_strtoul is obsolete, use kstrtoul instead
#122: FILE: drivers/edac/fsl_ddr_edac.c:96:
+                         simple_strtoul(data, NULL, 0));

Please send a fix ontop.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--