linux-kernel - A potential data race in drivers/net/ethernet/smsc/smc91c92

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f6391dbe-c692-d88c-9877-79270fce397b@ispras.ru>
Date:	Fri, 12 Aug 2016 12:54:07 +0300
From:	Pavel Andrianov <andrianov@...ras.ru>
To:	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	Mugunthan V N <mugunthanvnm@...com>
Cc:	Antonio Quartulli <a@...table.cc>, Florian Westphal <fw@...len.de>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Vaishali Thakkar <vaishali.thakkar@...cle.com>,
	ldv-project@...uxtesting.org
Subject: A potential data race in drivers/net/ethernet/smsc/smc91c92_cs.ko

Hi!

There is a potential data race in drivers/net/ethernet/smsc/smc91c92_cs.ko.
Regard two threads:

Thread 1 			Thread 2
				...
...				->smc_open
->smc_tx_timeout		  ->mod_timer 	
   -> smc_reset			    ->media_check - timer function
     -> smc_set_xcvr		      ->smc_set_xcvr	

In this case the struct 'smc' is modified from two threads 
simultaneously. Likely, the first thread should acquire the same 
spinlock smc->lock as the second thread in media_check.

-- 
Pavel Andrianov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: andrianov@...ras.ru