linux-kernel - Re: [linux-sunxi] [PATCH RFC 3/3] ARM: dts: sun8i: add hwspinlock device to sun8i-h3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72a2d7ef-54c9-a2dd-c83a-bf994b3005ce@redhat.com>
Date:	Fri, 12 Aug 2016 13:49:23 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	clabbe.montjoie@...il.com, ohad@...ery.com,
	bjorn.andersson@...aro.org
Cc:	linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-sunxi@...glegroups.com
Subject: Re: [linux-sunxi] [PATCH RFC 3/3] ARM: dts: sun8i: add hwspinlock
 device to sun8i-h3

Hi,

On 12-08-16 13:46, LABBE Corentin wrote:
> Add the hwspinlock device tree node for the device present on H3.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
> ---
>  arch/arm/boot/dts/sun8i-h3.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 439e8ed..c801389 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -489,6 +489,16 @@
>  			status = "disabled";
>  		};
>
> +		hwspinlock: hwspinlock@...8000 {
> +			compatible = "allwinner,sun8i-hwspinlock";
> +			reg = <0x01c18000 0x400>;
> +			resets = <&ccu RST_BUS_SPINLOCK>;
> +			reset-names = "ahb";
> +			clocks = <&ccu CLK_BUS_SPINLOCK>;
> +			clock-names = "ahb";
> +			status = "disabled";
> +		};
> +
>  		gic: interrupt-controller@...81000 {
>  			compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic";
>  			reg = <0x01c81000 0x1000>,
>

Why status=disabled? If this is a core part of the SoC, which Linux
can use, then IMHO it should be always enabled, like e.g. we also
always enable the timers.

Regards,

Habs