linux-kernel - Re: [PATCH] crypto: fix ctx pointer in sha512-mb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471018684.2888.41.camel@linux.intel.com>
Date:	Fri, 12 Aug 2016 09:18:04 -0700
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	Xiaodong Liu <xiaodong.liu@...el.com>, herbert@...dor.apana.org.au
Cc:	linux-crypto@...r.kernel.org, megha.dey@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: fix ctx pointer in sha512-mb

On Fri, 2016-08-12 at 06:28 -0400, Xiaodong Liu wrote:
> Signed-off-by: Xiaodong Liu <xiaodong.liu@...el.com>
> ---
>  arch/x86/crypto/sha512-mb/sha512_mb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/crypto/sha512-mb/sha512_mb.c b/arch/x86/crypto/sha512-mb/sha512_mb.c
> index f4cf5b7..d210174 100644
> --- a/arch/x86/crypto/sha512-mb/sha512_mb.c
> +++ b/arch/x86/crypto/sha512-mb/sha512_mb.c
> @@ -497,10 +497,10 @@ static int sha_complete_job(struct mcryptd_hash_request_ctx *rctx,
>  
>  			req = cast_mcryptd_ctx_to_req(req_ctx);
>  			if (irqs_disabled())
> -				rctx->complete(&req->base, ret);
> +				req_ctx->complete(&req->base, ret);
>  			else {
>  				local_bh_disable();
> -				rctx->complete(&req->base, ret);
> +				req_ctx->complete(&req->base, ret);
>  				local_bh_enable();
>  			}
>  		}

Changes look fine to me.

Acked.

Tim