linux-kernel - Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160812172402.GA31526@arbab-vm.austin.ibm.com>
Date:	Fri, 12 Aug 2016 12:24:03 -0500
From:	Reza Arbab <arbab@...ux.vnet.ibm.com>
To:	Balbir Singh <bsingharora@...il.com>
Cc:	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Jonathan Corbet <corbet@....net>,
	Bharata B Rao <bharata@...ux.vnet.ibm.com>,
	Nathan Fontenot <nfont@...ux.vnet.ibm.com>,
	devicetree@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-doc@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless
 node

On Fri, Aug 12, 2016 at 11:50:43AM +1000, Balbir Singh wrote:
>On 09/08/16 04:27, Reza Arbab wrote:
>> Remove the check which prevents us from hotplugging into an empty node.
>
>Do we want to do this only for ibm,hotplug-aperture compatible ranges?

We could, but since past discussions and current testing have been 
unable to justify preventing hotplug to a memoryless node in the first 
place, I'm inclined to keep things simple.

If some edge case is discovered, making it conditional as you describe 
will be a good solution.

Thanks for your review! A v2 of this set is pending my investigation of 
Michael's suggestion to get node hotadd working.

-- 
Reza Arbab