linux-kernel - Re: [PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160812184336.GA5706@rob-hp-laptop>
Date:	Fri, 12 Aug 2016 13:43:37 -0500
From:	Rob Herring <robh@...nel.org>
To:	Dongpo Li <lidongpo@...ilicon.com>
Cc:	mark.rutland@....com, mturquette@...libre.com,
	sboyd@...eaurora.org, linux@...linux.org.uk,
	zhangfei.gao@...aro.org, yisen.zhuang@...wei.com,
	salil.mehta@...wei.com, davem@...emloft.net, arnd@...db.de,
	andrew@...n.ch, xuejiancheng@...ilicon.com,
	benjamin.chenhao@...ilicon.com, howell.yang@...ilicon.com,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature

On Thu, Aug 11, 2016 at 05:01:52PM +0800, Dongpo Li wrote:
> From: Li Dongpo <lidongpo@...ilicon.com>
> 
> The "hix5hd2" is SoC name, add the generic ethernet driver name.
> The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds
> the SG/TXCSUM/TSO/UFO features.
> This patch only adds the SG(scatter-gather) driver for transmitting,
> the drivers of other features will be submitted later.

The compatible string changes should probably be a separate patch.

> Signed-off-by: Dongpo Li <lidongpo@...ilicon.com>
> ---
>  .../bindings/net/hisilicon-hix5hd2-gmac.txt        |   9 +-
>  drivers/net/ethernet/hisilicon/hix5hd2_gmac.c      | 213 +++++++++++++++++++--
>  2 files changed, 205 insertions(+), 17 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
> index 75d398b..3c02fac 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
> @@ -1,7 +1,12 @@
>  Hisilicon hix5hd2 gmac controller
>  
>  Required properties:
> -- compatible: should be "hisilicon,hix5hd2-gmac".
> +- compatible: should contain one of the following version strings:
> +	* "hisilicon,hisi-gemac-v1"
> +	* "hisilicon,hisi-gemac-v2"
> +	and one of the following SoC string:
> +	* "hisilicon,hix5hd2-gemac"
> +	* "hisilicon,hi3798cv200-gemac"

Make it clear what the order should be.

2 SOC versions so far and 2 generic versions. I'm not really convinced 
that the generic string is needed.

>  - reg: specifies base physical address(s) and size of the device registers.
>    The first region is the MAC register base and size.
>    The second region is external interface control register.
> @@ -20,7 +25,7 @@ Required properties:
>  
>  Example:
>  	gmac0: ethernet@...40000 {
> -		compatible = "hisilicon,hix5hd2-gmac";
> +		compatible = "hisilicon,hix5hd2-gemac", "hisilicon,hisi-gemac-v1";
>  		reg = <0xf9840000 0x1000>,<0xf984300c 0x4>;
>  		interrupts = <0 71 4>;
>  		#address-cells = <1>;