linux-kernel - Re: [PATCH 2/2] be2iscsi: Fix some error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cd24bc3-7953-479a-1dbe-2aac9299ce13@wanadoo.fr>
Date:	Fri, 12 Aug 2016 22:30:29 +0200
From:	Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	jayamohan.kallickal@...gotech.com, jejb@...ux.vnet.ibm.com,
	ketan.mukadam@...gotech.com, sony.john@...gotech.com,
	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] be2iscsi: Fix some error messages

Le 12/08/2016 à 12:30, Julia Lawall a écrit :
> On Fri, 12 Aug 2016, Christophe JAILLET wrote:
>
>> This fixes:
>>     - missing spaces in string split on several lines
>>     - extra spaces after ':'
>>     - missing '\n' at the end of some messages
>>     - too long lines
> I think that the strings should be concatenated, even if they go past 80
> chars.  I'm surprised checkpatch didn't complain.
>
> julia

checkpatch did complain.
In this file, all logging messages were written with split lines when 
too long, so I considered that it was better to keep it like that.

I will resubmit if the patch gets some interest and if a maintainer ask 
for concatenated messages.

CJ

---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus