linux-kernel - Re: [RESEND PATCH v4] x86/hpet: Reduce HPET counter read contention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57AE3B61.5010202@hpe.com>
Date:	Fri, 12 Aug 2016 17:10:57 -0400
From:	Waiman Long <waiman.long@....com>
To:	Andy Lutomirski <luto@...capital.net>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>,
	Ingo Molnar <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Borislav Petkov <bp@...e.de>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Randy Wright <rwright@....com>,
	Scott J Norton <scott.norton@....com>,
	Douglas Hatch <doug.hatch@....com>,
	Dave Hansen <dave.hansen@...el.com>,
	Prarit Bhargava <prarit@...hat.com>, X86 ML <x86@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [RESEND PATCH v4] x86/hpet: Reduce HPET counter read contention

On 08/12/2016 04:18 PM, Andy Lutomirski wrote:
> On Aug 12, 2016 9:31 PM, "Waiman Long"<waiman.long@....com>  wrote:
>> On 08/12/2016 01:16 PM, Dave Hansen wrote:
>>> On 08/12/2016 10:01 AM, Waiman Long wrote:
>>>> The reason for using a special lock is that I want both sequence number
>>>> update and locking to be done together atomically. They can be made
>>>> separate as is in the seqlock. However, that will make the code more
>>>> complex to make sure that all the threads see a consistent set of lock
>>>> state and sequence number.
>>> Why do we need a sequence number?  The "cached" HPET itself could be used.
>>>
>>> I'm thinking something like below could use a spinlock instead of the
>>> doing a custom cmpxchg sequence.  The spin_is_locked() should allow the
>>> contended "readers" to avoid using atomics.
>>>
>>> spinlock_t hpet_lock;
>>> u32 hpet_value;
>>> ...
>>> {
>>>          u32 old_hpet = READ_ONCE(hpet_value);
>>>          u32 new_hpet;
>>>
>>>          // need to ensure that the spin_is_locked() is ordered after
>>>          // the READ_ONCE().
>>>          smp_rmb();
>>>          // spin_is_locked() doesn't do atomics
>>>          if (!spin_is_locked(&hpet_lock)&&   spin_trylock(&hpet_lock)) {
>>>
>>>                  WRITE_ONCE(hpet_value, real_read_hpet());
>>>                  spin_unlock(&hpet_lock);
>>>                  return hpet_value;
>>>          }
>>>          // Contended case.  We spin here waiting for the guy who holds
>>>          // the lock to write a new value to 'hpet_value'.
>>>          //
>>>          // We know that our old_hpet is older than our check for the
>>>          // spinlock being locked. So, someone must either have already
>>>          // updated it or be updating it.
>>>          do {
>>>                  cpu_relax();
>>>                  // We do not do a rmb() here.  We don't need a guarantee
>>>                  // that this read is up-to-date, just that it will
>>>                  // _eventually_ see an up-to-date value.
>>>                  new_hpet = READ_ONCE(hpet_value);
>>>          } while (old_hpet == new_hpet);
>>>          return new_hpet;
>>> }
>>
>> Yes, I think that work too. I will update my patch accordingly. Thanks for the input.
> Why is Dave more convincing than I was a couple months ago when I
> asked a similar question? :)

I thought I made some changes in accordance with your comments 
previously. Maybe I missed something:-[

> I don't think this is right.  If the HPET ever returns the same value
> twice in a row (unlikely because it's generally too slow to read, but
> it's plausible that someone will make a fast HPET some day), then this
> could deadlock.

What is the deadlock scenario you are talking about?

>
> Also, does this code need to be NMI-safe?  This implementation is
> deadlocky if it's called from an NMI.

The code isn't NMI-safe as it is not maskable. So is the original code. 
We can check the interrupt state and read HPET directly if in NMI.


>
> The original code was wait-free, right?  That was a nice property, too.
>
> --Andy

The v4 patch isn't wait-free as need to make sure that we read the new 
HPET value instead of the stale one.

Cheers,
Longman