linux-kernel - Re: kmemleak: Cannot insert 0xff7f1000 into the object search tree (overlaps existing)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3495507-abf9-8df6-057d-32016bd4f221@ti.com>
Date:	Fri, 12 Aug 2016 09:45:05 +0530
From:	Vignesh R <vigneshr@...com>
To:	Catalin Marinas <catalin.marinas@....com>,
	"Strashko, Grygorii" <grygorii.strashko@...com>
CC:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: kmemleak: Cannot insert 0xff7f1000 into the object search tree
 (overlaps existing)

Hi Catalin,

Thanks for the response!

On Thursday 11 August 2016 10:38 PM, Catalin Marinas wrote:
> On Thu, Aug 11, 2016 at 07:48:12PM +0300, Grygorii Strashko wrote:
>> On 08/11/2016 06:54 PM, Catalin Marinas wrote:
>>> On Thu, Aug 11, 2016 at 05:20:51PM +0530, Vignesh R wrote:
>>>> I see the below message from kmemleak when booting linux-next on AM335x
>>>> GP EVM and DRA7 EVM
>>>
>>> Can you also reproduce it with 4.8-rc1?

Yes, I can reproduce this on 4.8.0-rc1-g4b9eaf33d83d

[...]
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 483197ef613f..7d3361d53ac2 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -723,7 +723,8 @@ int __init_memblock memblock_free(phys_addr_t base, phys_addr_t size)
>  		     (unsigned long long)base + size - 1,
>  		     (void *)_RET_IP_);
>  
> -	kmemleak_free_part(__va(base), size);
> +	if (base < __pa(high_memory))
> +		kmemleak_free_part(__va(base), size);
>  	return memblock_remove_range(&memblock.reserved, base, size);
>  }
>  
> @@ -1152,7 +1153,8 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size,
>  		 * The min_count is set to 0 so that memblock allocations are
>  		 * never reported as leaks.
>  		 */
> -		kmemleak_alloc(__va(found), size, 0, 0);
> +		if (found < __pa(high_memory))
> +			kmemleak_alloc(__va(found), size, 0, 0);
>  		return found;
>  	}
>  	return 0;
> @@ -1399,7 +1401,8 @@ void __init __memblock_free_early(phys_addr_t base, phys_addr_t size)
>  	memblock_dbg("%s: [%#016llx-%#016llx] %pF\n",
>  		     __func__, (u64)base, (u64)base + size - 1,
>  		     (void *)_RET_IP_);
> -	kmemleak_free_part(__va(base), size);
> +	if (base < __pa(high_memory))
> +		kmemleak_free_part(__va(base), size);
>  	memblock_remove_range(&memblock.reserved, base, size);
>  }
>  
> @@ -1419,7 +1422,8 @@ void __init __memblock_free_late(phys_addr_t base, phys_addr_t size)
>  	memblock_dbg("%s: [%#016llx-%#016llx] %pF\n",
>  		     __func__, (u64)base, (u64)base + size - 1,
>  		     (void *)_RET_IP_);
> -	kmemleak_free_part(__va(base), size);
> +	if (base < __pa(high_memory))
> +		kmemleak_free_part(__va(base), size);
>  	cursor = PFN_UP(base);
>  	end = PFN_DOWN(base + size);
>  
> 

With above change on 4.8-rc1, I see a different warning from kmemleak:

[    0.002918] kmemleak: Trying to color unknown object at 0xfe800000 as
Black
[    0.002943] CPU: 0 PID: 0 Comm: swapper/0 Not tainted
4.8.0-rc1-00121-g4b9eaf33d83d-dirty #59
[    0.002955] Hardware name: Generic AM33XX (Flattened Device Tree)
[    0.003000] [<c01100fc>] (unwind_backtrace) from [<c010c264>]
(show_stack+0x10/0x14)
[    0.003027] [<c010c264>] (show_stack) from [<c049040c>]
(dump_stack+0xac/0xe0)
[    0.003052] [<c049040c>] (dump_stack) from [<c02971c0>]
(paint_ptr+0x78/0x9c)
[    0.003074] [<c02971c0>] (paint_ptr) from [<c0b25e20>]
(kmemleak_init+0x1cc/0x284)
[    0.003104] [<c0b25e20>] (kmemleak_init) from [<c0b00bc0>]
(start_kernel+0x2d8/0x3b4)
[    0.003122] [<c0b00bc0>] (start_kernel) from [<8000807c>] (0x8000807c)
[    0.003133] kmemleak: Early log backtrace:
[    0.003146]    [<c0b3c9cc>] dma_contiguous_reserve+0x80/0x94
[    0.003170]    [<c0b06810>] arm_memblock_init+0x130/0x184
[    0.003191]    [<c0b04210>] setup_arch+0x58c/0xc00
[    0.003208]    [<c0b00940>] start_kernel+0x58/0x3b4
[    0.003224]    [<8000807c>] 0x8000807c
[    0.003239]    [<ffffffff>] 0xffffffff

Full boot log: http://pastebin.ubuntu.com/23048180/

-- 
Thanks
Vignesh