| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1470979856-12290-1-git-send-email-huaitong.han@intel.com> Date: Fri, 12 Aug 2016 13:30:56 +0800 From: Huaitong Han <huaitong.han@...el.com> To: tglx@...utronix.de, mingo@...hat.com, hpa@...or.com Cc: x86@...nel.org, linux-kernel@...r.kernel.org, Huaitong Han <huaitong.han@...el.com> Subject: [PATCH] x86/x2apic: fix x2apic_cluster_probe null pointer percpu cpus_in_cluster is a pointer with CONFIG_CPUMASK_OFFSTACK, cpu_in_cluster is not alloced memory before x2apic_prepare_cpu is invoked, so cpumask_set_cpu would get a NULL pointer bug: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<ffffffff8105ac25>] x2apic_cluster_probe+0x35/0x70 Signed-off-by: Huaitong Han <huaitong.han@...el.com> --- arch/x86/kernel/apic/x2apic_cluster.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c index 6368fa6..6acb055 100644 --- a/arch/x86/kernel/apic/x2apic_cluster.c +++ b/arch/x86/kernel/apic/x2apic_cluster.c @@ -190,9 +190,10 @@ static int x2apic_cluster_probe(void) if (!x2apic_mode) return 0; - cpumask_set_cpu(cpu, per_cpu(cpus_in_cluster, cpu)); cpuhp_setup_state(CPUHP_X2APIC_PREPARE, "X2APIC_PREPARE", x2apic_prepare_cpu, x2apic_dead_cpu); + cpumask_set_cpu(cpu, per_cpu(cpus_in_cluster, cpu)); + return 1; } -- 1.8.3.1
Powered by blists - more mailing lists