linux-kernel - Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdffed8e-d269-6519-437e-6f731dbb9c05@wanadoo.fr>
Date:	Sat, 13 Aug 2016 14:31:01 +0200
From:	Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:	Joe Perches <joe@...ches.com>, jayamohan.kallickal@...gotech.com,
	jejb@...ux.vnet.ibm.com, ketan.mukadam@...gotech.com,
	sony.john@...gotech.com, martin.petersen@...cle.com
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages

Le 13/08/2016 à 13:35, Joe Perches a écrit :
>
>> @@ -268,7 +268,7 @@ static int beiscsi_eh_abort(struct scsi_cmnd *sc)
>>   				&nonemb_cmd.dma);
>>   	if (nonemb_cmd.va == NULL) {
>>   		beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_EH,
>> -			    "BM_%d : Failed to allocate memory for"
>> +			    "BM_%d : Failed to allocate memory for "
>>   			    "mgmt_invalidate_icds\n");
> doesn't match commit log as no coalescing/concatenation
> is done.
>
> There are many of these.
>
I have *only* fixed the one reported by checkpatch and left the others 
unchanged.

My initial proposal was to fix incorrect strings, without modifying too 
much the code. So I decided to do the minimum of changes.

Should I resubmitted with:
    - all strings *in the patch* concatenated?
    - all strings *in the file*" concatenated?

CJ


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus