linux-kernel - Re: [PATCH net 2/4] hv_netvsc: reset vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160812.204048.1773150628029363073.davem@davemloft.net>
Date:	Fri, 12 Aug 2016 20:40:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vkuznets@...hat.com
Cc:	netdev@...r.kernel.org, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, haiyangz@...rosoft.com,
	kys@...rosoft.com
Subject: Re: [PATCH net 2/4] hv_netvsc: reset vf_inject on VF removal

From: Vitaly Kuznetsov <vkuznets@...hat.com>
Date: Thu, 11 Aug 2016 12:58:55 +0200

> We reset vf_inject on VF going down (netvsc_vf_down()) but we don't on
> VF removal (netvsc_unregister_vf()) so vf_inject stays 'true' while
> vf_netdev is already NULL and we're trying to inject packets into NULL
> net device in netvsc_recv_callback() causing kernel to crash.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

You can't create a blocking operation problem knowingly in this
patch just because you fix it in patch #4.

You must order your patches such that the driver does not regress
at any intermediate stage of your patch series.