lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 13 Aug 2016 18:42:51 +0100 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Milo Kim" <milo.kim@...com>, "Lee Jones" <lee.jones@...aro.org>, "Dan Carpenter" <dan.carpenter@...cle.com> Subject: [PATCH 3.16 014/305] mfd: lp8788-irq: Uninitialized variable in irq handler 3.16.37-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter <dan.carpenter@...cle.com> commit 22aab38e7b59fd79ce1045006be69a9abab58e5a upstream. Instead to being true/false, the "handled" is true/uninitialized. Presumably this doesn't cause that many problems in real life because normally we handle the IRQ. Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver') Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Acked-by: Milo Kim <milo.kim@...com> Signed-off-by: Lee Jones <lee.jones@...aro.org> Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- drivers/mfd/lp8788-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mfd/lp8788-irq.c +++ b/drivers/mfd/lp8788-irq.c @@ -110,7 +110,7 @@ static irqreturn_t lp8788_irq_handler(in struct lp8788_irq_data *irqd = ptr; struct lp8788 *lp = irqd->lp; u8 status[NUM_REGS], addr, mask; - bool handled; + bool handled = false; int i; if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))
Powered by blists - more mailing lists