linux-kernel - Re: [PATCH] rcutorture: Print out barrier error as document says

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160814024022.GH3482@linux.vnet.ibm.com>
Date:	Sat, 13 Aug 2016 19:40:22 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	SeongJae Park <sj38.park@...il.com>
Cc:	josh@...htriplett.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcutorture: Print out barrier error as document says

On Sat, Aug 13, 2016 at 03:54:35PM +0900, SeongJae Park wrote:
> Test for rcu_barrier() has introduced by commit fae4b54f28f0 ("rcu:
> Introduce rcutorture testing for rcu_barrier()").  Updated document says
> that `rtbe` field of output indicates failure of the test.  However, the
> code has not updated as so.  This commit updates the code to print out
> the field as document says.
> 
> Signed-off-by: SeongJae Park <sj38.park@...il.com>

Good catch, queue!

						Thanx, Paul

> ---
>  kernel/rcu/rcutorture.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index f0f32f8..ac29017 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -1259,8 +1259,9 @@ rcu_torture_stats_print(void)
>  		atomic_read(&n_rcu_torture_alloc),
>  		atomic_read(&n_rcu_torture_alloc_fail),
>  		atomic_read(&n_rcu_torture_free));
> -	pr_cont("rtmbe: %d rtbke: %ld rtbre: %ld ",
> +	pr_cont("rtmbe: %d rtbe: %ld rtbke: %ld rtbre: %ld ",
>  		atomic_read(&n_rcu_torture_mberror),
> +		n_rcu_torture_barrier_error,
>  		n_rcu_torture_boost_ktrerror,
>  		n_rcu_torture_boost_rterror);
>  	pr_cont("rtbf: %ld rtb: %ld nt: %ld ",
> -- 
> 1.9.1
>