lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 13 Aug 2016 20:45:25 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
	Wolfram Sang <wsa-dev@...g-engineering.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>
Subject: Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused
 "int ret" variable

On Sat, Aug 13, 2016 at 02:39:13PM -0400, Paul Gortmaker wrote:
> In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
> print error when adding adapter fails") the users of the variable
> were removed, resulting in:
> 
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
>   int ret;
>       ^
> 
> ...so here we remove the variable as well.
> 
> Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
> Cc: Wolfram Sang <wsa-dev@...g-engineering.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---

Acked-by: Wolfram Sang <wsa-dev@...g-engineering.com>

Thanks! I wonder how this slipped through my and the buildbot checks.
Will investigate...


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ