linux-kernel - [PATCH] perf evsel: remove redundant check of field being non-null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1471113662-20025-1-git-send-email-colin.king@canonical.com>
Date:	Sat, 13 Aug 2016 19:41:02 +0100
From:	Colin King <colin.king@...onical.com>
To:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Wang Nan <wangnan0@...wei.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] perf evsel: remove redundant check of field being non-null

From: Colin Ian King <colin.king@...onical.com>

The check if field is non-null in the ternary operator is
redundant since this check is made in the previousl if statement.
Remove this redundant check.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index d9b80ef..f4b1206 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2341,7 +2341,7 @@ u64 perf_evsel__intval(struct perf_evsel *evsel, struct perf_sample *sample,
 	if (!field)
 		return 0;
 
-	return field ? format_field__intval(field, sample, evsel->needs_swap) : 0;
+	return format_field__intval(field, sample, evsel->needs_swap);
 }
 
 bool perf_evsel__fallback(struct perf_evsel *evsel, int err,
-- 
2.8.1