linux-kernel - Re: [PATCH 0/2] be2iscsi: Logging neatening

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR0201MB18626C631DE6E5D09121608181110@BY2PR0201MB1862.namprd02.prod.outlook.com>
Date:	Sun, 14 Aug 2016 14:34:49 +0000
From:	Bart Van Assche <Bart.VanAssche@...disk.com>
To:	Joe Perches <joe@...ches.com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:	Jayamohan Kallickal <jayamohan.kallickal@...gotech.com>,
	Ketan Mukadam <ketan.mukadam@...gotech.com>,
	John Soni Jose <sony.john@...gotech.com>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] be2iscsi: Logging neatening

On 08/13/16 13:42, Joe Perches wrote:
> Joe Perches (2):
>   be2iscsi: Coalesce split strings and formats
>   be2iscsi: Use a standard logging style

Hello Joe,

As one can see in be_main.h the "level" argument of macro beiscsi_log() 
is ignored for log levels KERN_EMERG, KERN_ALERT, KERN_CRIT and
KERN_ERR. So for these log levels beiscsi_log() is a synonym of 
shost_printk(). Have you considered to replace beiscsi_log() with 
shost_printk() for these log levels and additionally to change 
beiscsi_log() for the other log levels into pr_debug()? pr_debug() 
statements namely already can be enabled and disabled at runtime. If the 
BEISCSI_LOG_* log category would be embedded in the log text that would 
allow to eliminate the phba->attr_log_enable structure member. 
Additionally, pr_debug() has a facility for displaying the source file 
name and the line number. That would allow to leave out __LINE__ from 
be2iscsi log statements. I don't think it is useful to have that line 
number in non-debug be2iscsi log statements.

Thanks,

Bart.