linux-kernel - Re: [LKP] [lkp] [xfs] 68a9f5e700: aim7.jobs-per-min -13.6% regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160814161724.GA20274@lst.de>
Date:	Sun, 14 Aug 2016 18:17:24 +0200
From:	Christoph Hellwig <hch@....de>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Christoph Hellwig <hch@....de>, Dave Chinner <david@...morbit.com>,
	Ye Xiaolong <xiaolong.ye@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Bob Peterson <rpeterso@...hat.com>, LKP <lkp@...org>
Subject: Re: [LKP] [lkp] [xfs] 68a9f5e700: aim7.jobs-per-min -13.6%
	regression

Snipping the long contest:

I think there are three observations here:

 (1) removing the mark_page_accessed (which is the only significant
     change in the parent commit)  hurts the
     aim7/1BRD_48G-xfs-disk_rr-3000-performance/ivb44 test.
     I'd still rather stick to the filemap version and let the
     VM people sort it out.  How do the numbers for this test
     look for XFS vs say ext4 and btrfs?
 (2) lots of additional spinlock contention in the new case.  A quick
     check shows that I fat-fingered my rewrite so that we do
     the xfs_inode_set_eofblocks_tag call now for the pure lookup
     case, and pretty much all new cycles come from that.
 (3) Boy, are those xfs_inode_set_eofblocks_tag calls expensive, and
     we're already doing way to many even without my little bug above.

So I've force pushed a new version of the iomap-fixes branch with
(2) fixed, and also a little patch to xfs_inode_set_eofblocks_tag a
lot less expensive slotted in before that.  Would be good to see
the numbers with that.