linux-kernel - Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Aug 2016 12:09:36 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Jonathan Corbet <corbet@....net>, Joe Perches <joe@...ches.com>
Cc:	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments"

On 08/14/16 11:35, Jonathan Corbet wrote:
> On Thu, 04 Aug 2016 10:55:14 -0700
> Joe Perches <joe@...ches.com> wrote:
> 
>>> Because Linus may still be reading source code on greenbar paper
>>> instead of color terminals with code syntax highlighting and
>>> appropriate font decorations.
>>>
>>> Link: http://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com
>>>
>>> Signed-off-by: Joe Perches <joe@...ches.com>
>>> ---
>>>  Documentation/CodingStyle | 3 ---
>>>  1 file changed, 3 deletions(-)
>>>
>>> diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
>>> index 9a70ddd..19b2e9c 100644
>>> --- a/Documentation/CodingStyle
>>> +++ b/Documentation/CodingStyle
>>> @@ -461,9 +461,6 @@ When commenting the kernel API functions, please use the kernel-doc format.
>>>  See the files Documentation/kernel-doc-nano-HOWTO.txt and scripts/kernel-doc
>>>  for details.
>>>  
>>> -Linux style for comments is the C89 "/* ... */" style.
>>> -Don't use C99-style "// ..." comments.
>>> -
>>>  The preferred style for long (multi-line) comments is:
>>>  
>>>  	/*  
>>
>> ping?
> 
> Sorry, I've not been ignoring this, I've just not yet worked up the
> courage to apply it.  Yes, Linus said he's fine with C++-style comments,
> but I still expect some pushback when people start actually sending them.
> I don't quite feel a sense of community consensus on this one.
> 
> Still, what the heck, I'll go ahead and apply it.  We can always revert it
> when people start screaming :)

I like it, but like Linus said, we don't want people to send
patches just to "fix" the comment style.

-- 
~Randy