linux-kernel - Re: [PATCH v2] perf symbols: Fix annotation of objects with debuginfo files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57B16BAB.2010003@huawei.com>
Date:	Mon, 15 Aug 2016 15:13:47 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Anton Blanchard <anton@....ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	"Arnaldo Carvalho de Melo" <acme@...nel.org>,
	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
	Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] perf symbols: Fix annotation of objects with debuginfo
 files



On 2016/8/13 9:55, Anton Blanchard wrote:
> From: Anton Blanchard <anton@...ba.org>
>
> Commit 73cdf0c6ea9c ("perf symbols: Record text offset in dso
> to calculate objdump address") started storing the offset of
> the text section for all DSOs:
>
>         if (elf_section_by_name(elf, &ehdr, &tshdr, ".text", NULL))
>                 dso->text_offset = tshdr.sh_addr - tshdr.sh_offset;
>
> Unfortunately this breaks debuginfo files, because we need to calculate
> the offset of the text section in the associated executable file. As a
> result perf annotate returns junk for all debuginfo files.
>
> Fix this by using runtime_ss->elf which should point at the executable
> when parsing a debuginfo file.
>
> Cc: stable@...r.kernel.org # v4.6+
> Fixes: 73cdf0c6ea9c ("perf symbols: Record text offset in dso to calculate objdump address")
> Signed-off-by: Anton Blanchard <anton@...ba.org>

I don't quite understand the debuginfo problem. I tested
this patch follow steps recorded in commit 99e87f7 and
see no problem.

Tested-by: Wang Nan <wangnan0@...wei.com>

Thank you.