linux-kernel - RE: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB4PR06MB2537EC6DC587FBA458D09FAD0120@DB4PR06MB253.eurprd06.prod.outlook.com>
Date:	Mon, 15 Aug 2016 07:10:27 +0000
From:	Jan Östlund <jao@....se>
To:	Daniel Romell <danielromell@...il.com>,
	"a.zummo@...ertech.it" <a.zummo@...ertech.it>
CC:	"alexandre.belloni@...e-electrons.com" 
	<alexandre.belloni@...e-electrons.com>,
	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Daniel Romell <Daro@....se>, Magnus Olsson <Mago@....se>
Subject: RE: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes'
 register.

Signed-off-by: Jan Östlund <jao@....se>

-----Original Message-----
From: Daniel Romell [mailto:danielromell@...il.com] 
Sent: den 11 augusti 2016 13:32
To: a.zummo@...ertech.it
Cc: alexandre.belloni@...e-electrons.com; rtc-linux@...glegroups.com; linux-kernel@...r.kernel.org; Daniel Romell <Daro@....se>; Jan Östlund <jao@....se>; Magnus Olsson <Mago@....se>
Subject: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.

From: Jan Östlund <jao@....se>

The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same
value. This is no functional change.

Signed-off-by: Daniel Romell <daro@....se>
---
 drivers/rtc/rtc-bq32k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c
index 0299988..5a0c137 100644
--- a/drivers/rtc/rtc-bq32k.c
+++ b/drivers/rtc/rtc-bq32k.c
@@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct rtc_time *tm)
 		return error;
 
 	tm->tm_sec = bcd2bin(regs.seconds & BQ32K_SECONDS_MASK);
-	tm->tm_min = bcd2bin(regs.minutes & BQ32K_SECONDS_MASK);
+	tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK);
 	tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK);
 	tm->tm_mday = bcd2bin(regs.date);
 	tm->tm_wday = bcd2bin(regs.day) - 1;
-- 
2.7.4