linux-kernel - [PATCH] drm: tilcdc: Fix check for remote port parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1471248988-13322-1-git-send-email-t.remmet@phytec.de>
Date:	Mon, 15 Aug 2016 10:16:28 +0200
From:	Teresa Remmet <t.remmet@...tec.de>
To:	Jyri Sarha <jsarha@...com>, Tomi Valkeinen <tomi.valkeinen@...com>
Cc:	David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] drm: tilcdc: Fix check for remote port parent

In function tilcdc_get_external_components the check for
the remote port parent is not correct. We need a '||' instead of
an '&&'.

Signed-off-by: Teresa Remmet <t.remmet@...tec.de>
---
There has been send out a different version of this patch about a year ago.
But there was no feedback at all. Please apply one of the solutions.

https://patchwork.kernel.org/patch/6596441/

Teresa

 drivers/gpu/drm/tilcdc/tilcdc_external.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.c b/drivers/gpu/drm/tilcdc/tilcdc_external.c
index 03acb4f..ceba712 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_external.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_external.c
@@ -145,7 +145,7 @@ int tilcdc_get_external_components(struct device *dev,
 		struct device_node *node;
 
 		node = of_graph_get_remote_port_parent(ep);
-		if (!node && !of_device_is_available(node)) {
+		if (!node || !of_device_is_available(node)) {
 			of_node_put(node);
 			continue;
 		}
-- 
1.9.1