| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1471251821.28498.7.camel@mtksdaap41>
Date: Mon, 15 Aug 2016 17:03:41 +0800
From: Tiffany Lin <tiffany.lin@...iatek.com>
To: Hans Verkuil <hverkuil@...all.nl>
CC: Hans Verkuil <hans.verkuil@...co.com>,
<daniel.thompson@...aro.org>, "Rob Herring" <robh+dt@...nel.org>,
Mauro Carvalho Chehab <mchehab@....samsung.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Daniel Kurtz <djkurtz@...omium.org>,
Pawel Osciak <posciak@...omium.org>,
Eddie Huang <eddie.huang@...iatek.com>,
Yingjoe Chen <yingjoe.chen@...iatek.com>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-media@...r.kernel.org>,
<linux-mediatek@...ts.infradead.org>, <PoChun.Lin@...iatek.com>
Subject: Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver
Hi Hans,
I upstream v4 on 8/10, I don't know why this version is not shown in
https://patchwork.kernel.org.
But I could see it in other link.
http://www.spinics.net/lists/arm-kernel/msg523095.html
I refine DocBook and vb2 queue_setup function in v4.
For the MT21 format, if I put MT21 into separate patch, this patch
series will build fail, I was confused how to fix this issue?
For VP9, I will merge this three patchs to V4L2 Decoder patch series.
* linux-media: [v1,1/3] videodev2.h: add V4L2_PIX_FMT_VP9 format.
- http://patchwork.linuxtv.org/patch/34392/
* linux-media: [v1,3/3] V4L: add VP9 format documentation
- http://patchwork.linuxtv.org/patch/34393/
* linux-media: [v1,2/3] v4l2-ioctl: add VP9 format description.
- http://patchwork.linuxtv.org/patch/34394/
best regards,
Tiffany
On Mon, 2016-08-15 at 10:30 +0200, Hans Verkuil wrote:
> Hi Tiffany,
>
> This needs a v4: the DocBook format has been replaced by sphinx, and I also see that
> the vb2 queue_setup function is out-of-date (the allocation contexts no longer exist).
>
> There were also a lot of comments about the MT21 format. I recommend splitting off the
> code adding MT21 into separate patches at the end of the patch series. That way if there
> are more comments it is easy to merge everything but those patches relating to MT21.
>
> Can you also add the patches for the new V4L2_PIX_FMT_VP9 to this patch series? Those
> needs to be updated as well due to the move to sphinx.
>
> Thanks!
>
> Hans
>
> On 05/30/2016 02:29 PM, Tiffany Lin wrote:
> > ==============
> > Introduction
> > ==============
> >
> > The purpose of this series is to add the driver for video codec hw embedded in the Mediatek's MT8173 SoCs.
> > Mediatek Video Codec is able to handle video decoding of in a range of formats.
> >
> > This patch series add Mediatek block format V4L2_PIX_FMT_MT21, the decoder driver will decoded bitstream to
> > V4L2_PIX_FMT_MT21 format.
> >
> > This patch series rely on MTK VPU driver in patch series "Add MT8173 Video Encoder Driver and VPU Driver"[1]
> > and patch "CHROMIUM: v4l: Add V4L2_PIX_FMT_VP9 definition"[2] for VP9 support.
> > Mediatek Video Decoder driver rely on VPU driver to load, communicate with VPU.
> >
> > Internally the driver uses videobuf2 framework and MTK IOMMU and MTK SMI both have been merged in v4.6-rc1.
> >
> > [1]https://patchwork.linuxtv.org/patch/33734/
> > [2]https://chromium-review.googlesource.com/#/c/245241/
> >
> > ==================
> > Device interface
> > ==================
> >
> > In principle the driver bases on v4l2 memory-to-memory framework:
> > it provides a single video node and each opened file handle gets its own private context with separate
> > buffer queues. Each context consist of 2 buffer queues: OUTPUT (for source buffers, i.e. bitstream)
> > and CAPTURE (for destination buffers, i.e. decoded video frames).
> > OUTPUT and CAPTURE buffer could be MMAP or DMABUF memory type.
> > VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS return V4L2_CID_MIN_BUFFERS_FOR_CAPTURE only when dirver in MTK_STATE_HEADER
> > state, or it will return EAGAIN.
> > Driver do not support subscribe event for control 'User Controls' for now.
> > And it default support export DMABUF for other display drivers.
> >
> > Change in v3:
> > 1. Refine vdec hw clock setting
> > 2. Refine vp9 codec driver
> > 3. Refine v4l2 codec driver
> >
> > Change in v2:
> > 1. Add documentation for V4L2_PIX_FMT_MT21
> > 2. Remove DRM_FORMAT_MT21
> > 2. Refine code according to review comments
> >
> > v4l2-compliance test output:
> > localhost Encode # ./v4l2-compliance -d /dev/video0
> > Driver Info:
> > Driver name : mtk-vcodec-dec
> > Card type : platform:mt8173
> > Bus info : platform:mt8173
> > Driver version: 4.4.0
> > Capabilities : 0x84204000
> > Video Memory-to-Memory Multiplanar
> > Streaming
> > Extended Pix Format
> > Device Capabilities
> > Device Caps : 0x04204000
> > Video Memory-to-Memory Multiplanar
> > Streaming
> > Extended Pix Format
> >
> > Compliance test for device /dev/video0 (not using libv4l2):
> >
> > Required ioctls:
> > test VIDIOC_QUERYCAP: OK
> >
> > Allow for multiple opens:
> > test second video open: OK
> > test VIDIOC_QUERYCAP: OK
> > test VIDIOC_G/S_PRIORITY: OK
> >
> > Debug ioctls:
> > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
> > test VIDIOC_LOG_STATUS: OK (Not Supported)
> >
> > Input ioctls:
> > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
> > test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
> > test VIDIOC_ENUMAUDIO: OK (Not Supported)
> > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
> > test VIDIOC_G/S_AUDIO: OK (Not Supported)
> > Inputs: 0 Audio Inputs: 0 Tuners: 0
> >
> > Output ioctls:
> > test VIDIOC_G/S_MODULATOR: OK (Not Supported)
> > test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> > test VIDIOC_ENUMAUDOUT: OK (Not Supported)
> > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
> > test VIDIOC_G/S_AUDOUT: OK (Not Supported)
> > Outputs: 0 Audio Outputs: 0 Modulators: 0
> >
> > Input/Output configuration ioctls:
> > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
> > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
> > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
> > test VIDIOC_G/S_EDID: OK (Not Supported)
> >
> > Control ioctls:
> > test VIDIOC_QUERYCTRL/MENU: OK
> > fail: ../../../v4l-utils-1.6.0/utils/v4l2-compliance/v4l2-test-controls.cpp(357): g_ctrl returned an error (11)
> > test VIDIOC_G/S_CTRL: FAIL
> > fail: ../../../v4l-utils-1.6.0/utils/v4l2-compliance/v4l2-test-controls.cpp(579): g_ext_ctrls returned an error (11)
> > test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL
> > fail: ../../../v4l-utils-1.6.0/utils/v4l2-compliance/v4l2-test-controls.cpp(721): subscribe event for control 'User Controls' failed
> > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL
> > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
> > Standard Controls: 2 Private Controls: 0
> >
> > Format ioctls:
> > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
> > test VIDIOC_G/S_PARM: OK (Not Supported)
> > test VIDIOC_G_FBUF: OK (Not Supported)
> > fail: ../../../v4l-utils-1.6.0/utils/v4l2-compliance/v4l2-test-formats.cpp(405): expected EINVAL, but got 11 when getting format for buftype 9
> > test VIDIOC_G_FMT: FAIL
> > test VIDIOC_TRY_FMT: OK (Not Supported)
> > test VIDIOC_S_FMT: OK (Not Supported)
> > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
> >
> > Codec ioctls:
> > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
> > test VIDIOC_G_ENC_INDEX: OK (Not Supported)
> > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
> >
> > Buffer ioctls:
> > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> > fail: ../../../v4l-utils-1.6.0/utils/v4l2-compliance/v4l2-test-buffers.cpp(500): q.has_expbuf(node)
> > test VIDIOC_EXPBUF: FAIL
> >
> >
> > Total: 38, Succeeded: 33, Failed: 5, Warnings: 0
> >
> >
> > Andrew-CT Chen (1):
> > VPU: mediatek: Add decode support
> >
> > Tiffany Lin (8):
> > v4l: add Mediatek compressed video block format
> > DocBook/v4l: Add compressed video formats used on MT8173 codec driver
> > dt-bindings: Add a binding for Mediatek Video Decoder
> > vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
> > vcodec: mediatek: Add Mediatek H264 Video Decoder Driver
> > vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver
> > vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver
> > arm64: dts: mediatek: Add Video Decoder for MT8173
> >
> > Documentation/DocBook/media/v4l/pixfmt.xml | 6 +
> > .../devicetree/bindings/media/mediatek-vcodec.txt | 57 +-
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 +
> > drivers/media/platform/mtk-vcodec/Makefile | 15 +-
> > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1348 ++++++++++++++++++++
> > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h | 88 ++
> > .../media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 408 ++++++
> > .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 206 +++
> > .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 28 +
> > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 88 +-
> > .../media/platform/mtk-vcodec/mtk_vcodec_intr.c | 4 +-
> > .../media/platform/mtk-vcodec/mtk_vcodec_intr.h | 2 +-
> > .../media/platform/mtk-vcodec/mtk_vcodec_util.c | 31 +-
> > .../media/platform/mtk-vcodec/mtk_vcodec_util.h | 7 +-
> > .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c | 503 ++++++++
> > .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c | 630 +++++++++
> > .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 967 ++++++++++++++
> > drivers/media/platform/mtk-vcodec/vdec_drv_base.h | 56 +
> > drivers/media/platform/mtk-vcodec/vdec_drv_if.c | 117 ++
> > drivers/media/platform/mtk-vcodec/vdec_drv_if.h | 101 ++
> > drivers/media/platform/mtk-vcodec/vdec_ipi_msg.h | 103 ++
> > drivers/media/platform/mtk-vcodec/vdec_vpu_if.c | 168 +++
> > drivers/media/platform/mtk-vcodec/vdec_vpu_if.h | 96 ++
> > drivers/media/platform/mtk-vpu/mtk_vpu.c | 12 +
> > drivers/media/platform/mtk-vpu/mtk_vpu.h | 27 +
> > include/uapi/linux/videodev2.h | 1 +
> > 26 files changed, 5090 insertions(+), 23 deletions(-)
> > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h
> > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_vp8_if.c
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_base.h
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_if.c
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_if.h
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec_ipi_msg.h
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec_vpu_if.c
> > create mode 100644 drivers/media/platform/mtk-vcodec/vdec_vpu_if.h
> >
Powered by blists - more mailing lists