linux-kernel - Re: [PATCH v4 2/3] arm64: vdso: constify vm_special

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160815091754.GC1426@svinekod>
Date:	Mon, 15 Aug 2016 10:17:54 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	catalin.marinas@....com, will.deacon@....com,
	lorenzo.pieralisi@....com, keescook@...omium.org,
	ard.biesheuvel@...aro.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] arm64: vdso: constify vm_special_mapping used for
 aarch32 vectors page

On Mon, Aug 15, 2016 at 02:45:45PM +0800, Jisheng Zhang wrote:
> The vm_special_mapping spec which is used for aarch32 vectors page is
> never modified, so mark it as const.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>

I see that this is never deliberately modified before being passed to
_install_special_mapping, which takes it as a const pointer. So this looks good
to me:

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.

> ---
>  arch/arm64/kernel/vdso.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
> index e320e8f..10ad8ab 100644
> --- a/arch/arm64/kernel/vdso.c
> +++ b/arch/arm64/kernel/vdso.c
> @@ -88,7 +88,7 @@ int aarch32_setup_vectors_page(struct linux_binprm *bprm, int uses_interp)
>  {
>  	struct mm_struct *mm = current->mm;
>  	unsigned long addr = AARCH32_VECTORS_BASE;
> -	static struct vm_special_mapping spec = {
> +	static const struct vm_special_mapping spec = {
>  		.name	= "[vectors]",
>  		.pages	= vectors_page,
>  
> -- 
> 2.8.1
>