linux-kernel - [PATCH v6 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471252398-957-9-git-send-email-peter.chen@nxp.com>
Date:	Mon, 15 Aug 2016 17:13:18 +0800
From:	Peter Chen <peter.chen@....com>
To:	<gregkh@...uxfoundation.org>, <stern@...land.harvard.edu>,
	<ulf.hansson@...aro.org>, <broonie@...nel.org>, <sre@...nel.org>,
	<robh+dt@...nel.org>, <shawnguo@...nel.org>,
	<dbaryshkov@...il.com>, <dwmw3@...radead.org>
CC:	<k.kozlowski@...sung.com>, <linux-arm-kernel@...ts.infradead.org>,
	<p.zabel@...gutronix.de>, <devicetree@...r.kernel.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<linux-usb@...r.kernel.org>, <arnd@...db.de>,
	<s.hauer@...gutronix.de>, <mail@...iej.szmigiero.name>,
	<troy.kisky@...ndarydevices.com>, <festevam@...il.com>,
	<oscar@...andei.net>, <stephen.boyd@...aro.org>,
	<linux-pm@...r.kernel.org>, <stillcompiling@...il.com>,
	<linux-kernel@...r.kernel.org>, <mka@...omium.org>,
	Peter Chen <peter.chen@....com>
Subject: [PATCH v6 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line

From: Joshua Clayton <stillcompiling@...il.com>

Previously the onboard hub was made to work by treating its
reset gpio as a regulator enable.
Get rid of that kludge now that pwseq has added reset gpio support
Move pin muxing the hub reset pin into the usbh1 group

Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
Signed-off-by: Peter Chen <peter.chen@....com>
---
 arch/arm/boot/dts/imx6q-evi.dts | 25 +++++++------------------
 1 file changed, 7 insertions(+), 18 deletions(-)

diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
index 4fa5601..49c6f61 100644
--- a/arch/arm/boot/dts/imx6q-evi.dts
+++ b/arch/arm/boot/dts/imx6q-evi.dts
@@ -54,18 +54,6 @@
 		reg = <0x10000000 0x40000000>;
 	};
 
-	reg_usbh1_vbus: regulator-usbhubreset {
-		compatible = "regulator-fixed";
-		regulator-name = "usbh1_vbus";
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-		enable-active-high;
-		startup-delay-us = <2>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&pinctrl_usbh1_hubreset>;
-		gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>;
-	};
-
 	reg_usb_otg_vbus: regulator-usbotgvbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb_otg_vbus";
@@ -204,12 +192,18 @@
 };
 
 &usbh1 {
-	vbus-supply = <&reg_usbh1_vbus>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbh1>;
 	dr_mode = "host";
 	disable-over-current;
 	status = "okay";
+
+	usb2415host: hub@1 {
+		compatible = "usb424,2513";
+		reg = <1>;
+		reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
+		reset-duration-us = <3000>;
+	};
 };
 
 &usbotg {
@@ -467,11 +461,6 @@
 			MX6QDL_PAD_GPIO_3__USB_H1_OC 0x1b0b0
 			/* usbh1_b OC */
 			MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x1b0b0
-		>;
-	};
-
-	pinctrl_usbh1_hubreset: usbh1hubresetgrp {
-		fsl,pins = <
 			MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b0b0
 		>;
 	};
-- 
1.9.1