lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 15 Aug 2016 10:53:28 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Joe Perches <joe@...ches.com>
Cc:	kbuild-all@...org, Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] block: skd_main: Neaten pr_debug uses by adding and
 using skd_dbg

Hi Joe,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.8-rc1 next-20160812]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Joe-Perches/block-skd_main-Neaten-pr_debug-uses-by-adding-and-using-skd_dbg/20160815-102230
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:13:0,
                    from drivers/block/skd_main.c:19:
   drivers/block/skd_main.c: In function 'skd_preop_sg_list':
   drivers/block/skd_main.c:91:11: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 8 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     pr_debug("%s:%s:%d " fmt,     \
              ^
   include/linux/printk.h:260:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^
   include/linux/printk.h:308:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^
   drivers/block/skd_main.c:91:2: note: in expansion of macro 'pr_debug'
     pr_debug("%s:%s:%d " fmt,     \
     ^
>> drivers/block/skd_main.c:866:3: note: in expansion of macro 'skd_dbg'
      skd_dbg(skdev, "skreq=%x sksg_list=%p sksg_dma=%llx\n",
      ^
   drivers/block/skd_main.c: In function 'skd_skreq_prep_buffering':
   drivers/block/skd_main.c:91:11: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 8 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     pr_debug("%s:%s:%d " fmt,     \
              ^
   include/linux/printk.h:260:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^
   include/linux/printk.h:308:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^
   drivers/block/skd_main.c:91:2: note: in expansion of macro 'pr_debug'
     pr_debug("%s:%s:%d " fmt,     \
     ^
   drivers/block/skd_main.c:1521:3: note: in expansion of macro 'skd_dbg'
      skd_dbg(skdev, "skreq=%x sksg_list=%p sksg_dma=%llx\n",
      ^
   drivers/block/skd_main.c: In function 'skd_send_fitmsg':
   drivers/block/skd_main.c:91:11: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     pr_debug("%s:%s:%d " fmt,     \
              ^
   include/linux/printk.h:260:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^
   include/linux/printk.h:308:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^
   drivers/block/skd_main.c:91:2: note: in expansion of macro 'pr_debug'
     pr_debug("%s:%s:%d " fmt,     \
     ^
   drivers/block/skd_main.c:2066:2: note: in expansion of macro 'skd_dbg'
     skd_dbg(skdev, "dma address 0x%llx, busy=%d\n",
     ^
   drivers/block/skd_main.c: In function 'skd_send_special_fitmsg':
   drivers/block/skd_main.c:91:11: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 9 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     pr_debug("%s:%s:%d " fmt,     \
              ^
   include/linux/printk.h:260:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^
   include/linux/printk.h:308:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^
   drivers/block/skd_main.c:91:2: note: in expansion of macro 'pr_debug'
     pr_debug("%s:%s:%d " fmt,     \
     ^
   drivers/block/skd_main.c:2126:3: note: in expansion of macro 'skd_dbg'
      skd_dbg(skdev, "skspcl=%p id=%04x sksg_list=%p sksg_dma=%llx\n",
      ^

vim +/skd_dbg +866 drivers/block/skd_main.c

   850		for (i = 0; i < n_sg; i++) {
   851			struct fit_sg_descriptor *sgd = &skreq->sksg_list[i];
   852			u32 cnt = sg_dma_len(&sg[i]);
   853			uint64_t dma_addr = sg_dma_address(&sg[i]);
   854	
   855			sgd->control = FIT_SGD_CONTROL_NOT_LAST;
   856			sgd->byte_count = cnt;
   857			skreq->sg_byte_count += cnt;
   858			sgd->host_side_addr = dma_addr;
   859			sgd->dev_side_addr = 0;
   860		}
   861	
   862		skreq->sksg_list[n_sg - 1].next_desc_ptr = 0LL;
   863		skreq->sksg_list[n_sg - 1].control = FIT_SGD_CONTROL_LAST;
   864	
   865		if (unlikely(skdev->dbg_level > 1)) {
 > 866			skd_dbg(skdev, "skreq=%x sksg_list=%p sksg_dma=%llx\n",
   867				skreq->id, skreq->sksg_list, skreq->sksg_dma_address);
   868			for (i = 0; i < n_sg; i++) {
   869				struct fit_sg_descriptor *sgd = &skreq->sksg_list[i];
   870				skd_dbg(skdev, "  sg[%d] count=%u ctrl=0x%x addr=0x%llx next=0x%llx\n",
   871					i, sgd->byte_count, sgd->control,
   872					sgd->host_side_addr, sgd->next_desc_ptr);
   873			}
   874		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (47053 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ