linux-kernel - Re: [PATCH v4 10/26] fs: btrfs: Use ktime_get_real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160815132649.GI30795@twin.jikos.cz>
Date:	Mon, 15 Aug 2016 15:26:49 +0200
From:	David Sterba <dsterba@...e.cz>
To:	Deepa Dinamani <deepa.kernel@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	arnd@...db.de, tglx@...utronix.de, torvalds@...ux-foundation.org,
	tytso@....edu, viro@...iv.linux.org.uk, y2038@...ts.linaro.org,
	Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
	Josef Bacik <jbacik@...com>, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH v4 10/26] fs: btrfs: Use ktime_get_real_ts for root ctime

On Sat, Aug 13, 2016 at 03:48:22PM -0700, Deepa Dinamani wrote:
> btrfs_root_item maintains the ctime for root updates.
> This is not part of vfs_inode.
> 
> Since current_time() uses struct inode* as an argument
> as Linus suggested, this cannot be used to update root
> times unless, we modify the signature to use inode.
> 
> Since btrfs uses nanosecond time granularity, it can also
> use ktime_get_real_ts directly to obtain timestamp for
> the root. It is necessary to use the timespec time api
> here because the same btrfs_set_stack_timespec_*() apis
> are used for vfs inode times as well. These can be
> transitioned to using timespec64 when btrfs internally
> changes to use timespec64 as well.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
> Acked-by: David Sterba <dsterba@...e.com>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Cc: Chris Mason <clm@...com>
> Cc: David Sterba <dsterba@...e.com>

Acked-by: David Sterba <dsterba@...e.com>