linux-kernel - Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1471273165.2428.7.camel@linux.vnet.ibm.com>
Date:	Mon, 15 Aug 2016 07:59:25 -0700
From:	James Bottomley <jejb@...ux.vnet.ibm.com>
To:	Johannes Thumshirn <jthumshirn@...e.de>
Cc:	kbuild test robot <lkp@...el.com>, kbuild-all@...org,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	Hannes Reinecke <hare@...e.de>,
	Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
	Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

On Mon, 2016-08-15 at 16:40 +0200, Johannes Thumshirn wrote:
> On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote:
> > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote:
> > > Hi Johannes,
> > > 
> > > [auto build test ERROR on scsi/for-next]
> > > [also build test ERROR on v4.8-rc2 next-20160815]
> > > [if your patch is applied to the wrong git tree, please drop us a
> > > note to help improve the system]
> > 
> > This is happening because scsi_is_sas_rphy wasn't designed to be 
> > used outside the SAS transport class, so it's failing when the 
> > ATTRs aren't defined.
> > 
> > This is the way you fix it (needs to be a precursor patch to 1/2):
> > 
> > James
> 
> Thanks, but I'm wondering about the call to sas_get_address(). It was
> there before the patch as well and now it's an undefined reference. 
> Am I missing something here? Sure it can be guarded in the #if block.

Yes: gcc is kind enough to elide any code that looks like

if (0) {
	refer to something
}

So the static inline ensures anything within the brace isn't used as a
linkable reference.

James