linux-kernel - Re: [PATCH] iio: light: us5182d: Add missing error code assignment before test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb543108-e601-6c8b-4158-51b9298d4e5e@kernel.org>
Date:	Mon, 15 Aug 2016 16:13:00 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net
Cc:	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio: light: us5182d: Add missing error code assignment
 before test

On 10/08/16 06:18, Christophe JAILLET wrote:
> It is likely that checking the result of 'pm_runtime_set_active' is
> expected here.
> 
> Fixes: f0e5f57d3ac2 ("iio: light: us8152d: Add power management support")
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Applied to the togreg branch of iio.git. Initially pushed out as testing
for the autobuilders to play with it.

Whilst the fix is obviously correct, the missing assignment just results in
a particular error not being handled rather than a 'bug' as such. Hence
I'm sending this the slow route and it'll hit in the next merge window.

Thanks,

Jonathan
> ---
>  drivers/iio/light/us5182d.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
> index 20c40f780964..18cf2e29e4d5 100644
> --- a/drivers/iio/light/us5182d.c
> +++ b/drivers/iio/light/us5182d.c
> @@ -894,7 +894,7 @@ static int us5182d_probe(struct i2c_client *client,
>  		goto out_err;
>  
>  	if (data->default_continuous) {
> -		pm_runtime_set_active(&client->dev);
> +		ret = pm_runtime_set_active(&client->dev);
>  		if (ret < 0)
>  			goto out_err;
>  	}
>