linux-kernel - Re: [PATCH 1/2] mtd: nand: timings: Fix tADL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160815171742.3b5d1fb6@bbrezillon>
Date:	Mon, 15 Aug 2016 17:17:42 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	linux-mtd@...ts.infradead.org,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Richard Weinberger <richard@....at>
Cc:	linux-kernel@...r.kernel.org,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>
Subject: Re: [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips

On Tue, 14 Jun 2016 16:21:06 +0200
Boris Brezillon <boris.brezillon@...e-electrons.com> wrote:

> ONFI 4.0 spec defines different values for the tADL_min timing.
> Since we don't want to have different timings depending on the ONFI
> version, we just set tADL_min to the maximum value (the one specified
> in the ONFI 4.0 spec).

Applied both.

> 
> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> ---
>  drivers/mtd/nand/nand_timings.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
> index e81470a..c0941d5 100644
> --- a/drivers/mtd/nand/nand_timings.c
> +++ b/drivers/mtd/nand/nand_timings.c
> @@ -16,7 +16,7 @@
>  static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	/* Mode 0 */
>  	{
> -		.tADL_min = 200000,
> +		.tADL_min = 400000,
>  		.tALH_min = 20000,
>  		.tALS_min = 50000,
>  		.tAR_min = 25000,
> @@ -53,7 +53,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 1 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 10000,
>  		.tALS_min = 25000,
>  		.tAR_min = 10000,
> @@ -90,7 +90,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 2 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 10000,
>  		.tALS_min = 15000,
>  		.tAR_min = 10000,
> @@ -127,7 +127,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 3 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,
> @@ -164,7 +164,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 4 */
>  	{
> -		.tADL_min = 70000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,
> @@ -201,7 +201,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 5 */
>  	{
> -		.tADL_min = 70000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,