linux-kernel - Re: [PATCH -next] drm/mgag200: fix error return code in mgag200fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160815160421.GL6232@phenom.ffwll.local>
Date:	Mon, 15 Aug 2016 18:04:21 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	airlied@...hat.com, airlied@...ux.ie, daniel.vetter@...ll.ch,
	architt@...eaurora.org, ville.syrjala@...ux.intel.com,
	alexander.deucher@....com, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/mgag200: fix error return code in
 mgag200fb_create()

On Mon, Aug 15, 2016 at 03:03:51PM +0000, Wei Yongjun wrote:
> Fix to return error code -ENOMEM from the vmalloc() error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: aec9e12953e7 ("drm/mgag200: Fix error handling paths in fbdev driver")
> Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/mgag200/mgag200_fb.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c
> index 81325f6..88dd221 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_fb.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_fb.c
> @@ -183,8 +183,10 @@ static int mgag200fb_create(struct drm_fb_helper *helper,
>  	}
>  
>  	sysram = vmalloc(size);
> -	if (!sysram)
> +	if (!sysram) {
> +		ret = -ENOMEM;
>  		goto err_sysram;
> +	}
>  
>  	info = drm_fb_helper_alloc_fbi(helper);
>  	if (IS_ERR(info)) {
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch