linux-kernel - Re: [PATCH] x86/power/64: Use __pa() for physical address computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160815051042.GC16267@gmail.com>
Date:	Mon, 15 Aug 2016 07:10:42 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/power/64: Use __pa() for physical address computation


* Rafael J. Wysocki <rjw@...ysocki.net> wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The value of temp_level4_pgt is the physical address of the
> top-level page directory, so use __pa() to compute it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  arch/x86/power/hibernate_64.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-pm/arch/x86/power/hibernate_64.c
> ===================================================================
> --- linux-pm.orig/arch/x86/power/hibernate_64.c
> +++ linux-pm/arch/x86/power/hibernate_64.c
> @@ -113,7 +113,7 @@ static int set_up_temporary_mappings(voi
>  			return result;
>  	}
>  
> -	temp_level4_pgt = (unsigned long)pgd - __PAGE_OFFSET;
> +	temp_level4_pgt = __pa(pgd);
>  	return 0;
>  }

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo