linux-kernel - Re: [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1471280995.2428.10.camel@linux.vnet.ibm.com>
Date:	Mon, 15 Aug 2016 10:09:55 -0700
From:	James Bottomley <jejb@...ux.vnet.ibm.com>
To:	Johannes Thumshirn <jthumshirn@...e.de>,
	"Martin K . Petersen" <martin.petersen@...cle.com>
Cc:	Hannes Reinecke <hare@...e.de>,
	Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
	Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] sas: provide stub implementations for
 scsi_is_sas_phy and sas_get_address

On Mon, 2016-08-15 at 17:12 +0200, Johannes Thumshirn wrote:
> +static inline u64 sas_get_address(struct scsi_device *sdev)
> +{
> +	return 0;
> +}

To be honest, we don't want this.  We do want the code to fail to
compile if you ever use sas_get_address where you shouldn't because the
code will be incorrect at that point.  If we could return an error,
fine, but we just return the address.

James