linux-kernel - [PATCH 21/22] IB/ipoib_verbs: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Aug 2016 23:44:47 +0530
From:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
To:	Yishai Hadas <yishaih@...lanox.com>,
	Doug Ledford <dledford@...hat.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Leon Romanovsky <leonro@...lanox.com>,
	Chuck Lever <chuck.lever@...cle.com>,
	Mark Bloch <markb@...lanox.com>,
	Hans Westgaard Ry <hans.westgaard.ry@...cle.com>,
	Christoph Lameter <cl@...ux.com>,
	Erez Shitrit <erezsh@...lanox.com>,
	Haggai Eran <haggaie@...lanox.com>,
	Florian Westphal <fw@...len.de>,
	Guy Shapiro <guysh@...lanox.com>, Eli Cohen <eli@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Faisal Latif <faisal.latif@...el.com>,
	Matan Barak <matanb@...lanox.com>,
	Chien Tin Tung <chien.tin.tung@...el.com>,
	Mustafa Ismail <mustafa.ismail@...el.com>,
	Shiraz Saleem <shiraz.saleem@...el.com>,
	Tatyana Nikolova <tatyana.e.nikolova@...el.com>,
	Steve Wise <swise@...lsio.com>,
	Mike Marciniszyn <infinipath@...el.com>,
	Bart Van Assche <bart.vanassche@...disk.com>,
	Yotam Kenneth <yotamke@...lanox.com>,
	Somnath Kotur <Somnath.Kotur@...gotech.Com>,
	Moni Shoua <monis@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Parav Pandit <pandit.parav@...il.com>,
	Sagi Grimberg <sagi@...mberg.me>,
	Christoph Hellwig <hch@...radead.org>,
	Dean Luick <dean.luick@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Kaike Wan <kaike.wan@...el.com>
Cc:	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tejun Heo <tj@...nel.org>
Subject: [PATCH 21/22] IB/ipoib_verbs: Remove deprecated
 create_singlethread_workqueue

alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "wq" queues mulitple work items viz &priv->restart_task,
&priv->cm.rx_reap_task, &priv->cm.skb_task, &priv->neigh_reap_task,
&priv->ah_reap_task, &priv->mcast_task and &priv->carrier_on_task.
The work items require strict execution ordering.
Hence, an ordered dedicated workqueue has been used.

WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
---
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_verbs.c b/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
index 1e7cbba..5737652 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
@@ -156,7 +156,7 @@ int ipoib_transport_dev_init(struct net_device *dev, struct ib_device *ca)
 	 * the various IPoIB tasks assume they will never race against
 	 * themselves, so always use a single thread workqueue
 	 */
-	priv->wq = create_singlethread_workqueue("ipoib_wq");
+	priv->wq = alloc_ordered_workqueue("ipoib_wq", WQ_MEM_RECLAIM);
 	if (!priv->wq) {
 		printk(KERN_WARNING "ipoib: failed to allocate device WQ\n");
 		goto out_free_pd;
--
2.1.4