linux-kernel - Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160815144740.GA7067@senary>
Date:	Mon, 15 Aug 2016 09:47:40 -0500
From:	Kyle Roeschley <kyle.roeschley@...com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
CC:	<richard@....at>, <dwmw2@...radead.org>,
	<computersforpeace@...il.com>, <beanhuo@...ron.com>,
	<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<nathan.sullivan@...com>, <xander.huff@...com>,
	<peterpansjtu@...il.com>
Subject: Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out
 of write_bbt()

On Sat, Aug 13, 2016 at 12:37:03AM +0200, Boris Brezillon wrote:
> On Fri, 12 Aug 2016 16:58:22 -0500
> Kyle Roeschley <kyle.roeschley@...com> wrote:
> 
[...]
> > +	while (chip < nrchips) {
> 
> I'm probably missing something, but why are you turning the for loop
> into a while loop in this patch? The commit message does not mention
> that, and I don't see why you need it before you actually start
> reworking the code to recover from BBT write failures (which is done in
> patch 2).
> 

You had changed it in patch 2 (http://code.bulix.org/e16nvo-104988) and I just
shuffled it to the first patch since it seemed to make sense as additional code
cleanup. I'll go ahead and drop it though if you don't want it in.

-- 
Kyle Roeschley
Software Engineer
National Instruments