linux-kernel - Re: [PATCH] net: hns: mdio->irq is an array, so no need to check if it is null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160815.133903.1454433408106419676.davem@davemloft.net>
Date:	Mon, 15 Aug 2016 13:39:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	colin.king@...onical.com
Cc:	yisen.zhuang@...wei.com, salil.mehta@...wei.com,
	yankejian@...wei.com, huangdaode@...ilicon.com,
	lipeng321@...wei.com, lisheng011@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hns: mdio->irq is an array, so no need to check
 if it is null

From: Colin King <colin.king@...onical.com>
Date: Mon, 15 Aug 2016 13:55:17 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> The null check on mdio->irq is redundant since mdio->irq is an array
> of PHY_MAX_ADDR ints and hence can never be null. Remove the redundant
> check.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.