linux-kernel - Re: [PATCH 1/2] staging: lustre: Add include path to Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471295658.4075.117.camel@perches.com>
Date:	Mon, 15 Aug 2016 14:14:18 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	lustre-devel@...ts.lustre.org
Subject: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile

On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > Start to rationalize include paths in source code files.
[]
> > diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile
[]
> > @@ -1,2 +1,5 @@
> > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/include/
> > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/lustre/include/
> > +
> >  obj-$(CONFIG_LNET)		+= lnet/
> >  obj-$(CONFIG_LUSTRE_FS)		+= lustre/
> This is good, but does this break the subdir make command:
> 	make M=drivers/staging/lustre/foo_dir/
> ?

hmm, yeah, it does.  Oh well, nevermind for awhile.

> I remember the last time I tried to clean this up, it took a while...

It seems like something the build tools should
handle correctly now, but I'll look at it.

No rush.