linux-kernel - Re: Building a subdirectory ignores parent subdir-ccflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471301196.4075.133.camel@perches.com>
Date:	Mon, 15 Aug 2016 15:46:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Michal Marek <mmarek@...e.com>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Yann E. MORIN" <yann.morin.1998@...e.fr>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	lustre-devel@...ts.lustre.org
Subject: Re: Building a subdirectory ignores parent subdir-ccflags

On Tue, 2016-08-16 at 00:07 +0200, Michal Marek wrote:

Hi Michal.

> > Perhaps making a specific directory should also walk up
> > any parent directory Makefiles looking for subdir flags.
> > 
> > Is that unreasonable?  Any suggestions?
> I suggest to do make drivers/staging/lustre/. If building the lustre
> subdirectories is going to be a common use case, then you can propagate
> the subdir-ccflags-y assignment down to the individual Makefiles.

I don't have a problem with that.

Others might though for whatever reason.

There are a couple other places in the tree that
also use subdir-ccflags where the results of making
a subdirectory would either fail or have unexpected
results.

Does it matter?  Not much, but it could be nicer if
it's possible for parent Makefile paths to be ascended.

I'm not much of a Makefile person, but perhaps you have
some clues/tips/suggestions for implementation?