linux-kernel - Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160815225333.GB3672@mtj.duckdns.org>
Date:	Mon, 15 Aug 2016 18:53:33 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Pali Rohár <pali.rohar@...il.com>,
	Chris Diamand <chris@...mand.org>,
	Stefan Assmann <sassmann@...nic.de>,
	Richard Pospesel <pospeselr@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Takashi Iwai <tiwai@...e.de>,
	patches@...nsource.wolfsonmicro.com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Input: wm97xx: Remove deprecated
 create_singletheread_workqueue

On Sun, Aug 14, 2016 at 10:56:38AM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion. The workqueue "ts_workq" has been identity converted.
> 
> It queues work items viz &wm->ts_reader and &wm->pen_event_work which map
> to wm97xx_pen_irq_worker (handles a pen down interrupt) and
> wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence,
> an ordered dedicated workqueue has been used.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> pressure.

I'm not sure WQ_MEM_RECLAIM makes sense on an input driver.

Thanks.

-- 
tejun