linux-kernel - Re: [PATCH] pnp: isapnp: make core more explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27266824.ex59zez5pz@vostro.rjw.lan>
Date:	Tue, 16 Aug 2016 01:32:04 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH] pnp: isapnp: make core more explicitly non-modular

On Monday, August 15, 2016 06:42:33 PM Paul Gortmaker wrote:
> The Makefile currently controlling compilation of this code is:
> 
> obj-y                   += pnp.o
> pnp-y                   := core.o compat.o
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> We don't replace module.h with init.h since the file already has that.
> But we do add moduleparam.h since the file does use module_param().
> 
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

I'll queue up this one for v4.9, thanks!

Best,
Rafael